fix: prevent interception of requests when Studio is not opened #32995
+116
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
prevent-intercept-studio-protocol
|
| Run status |
|
| Run duration | 20m 20s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
14
|
Pending
|
1097
|
Skipped
|
4
|
Passing
|
26698
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.61%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
161
|
Accessibility
98.01%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| proxyRequestCorrelationDuration: preRequest.proxyRequestCorrelationDuration, | ||
| }, | ||
| }) | ||
| // resultingStream will be undefined, so we continue with original stream |
There was a problem hiding this comment.
Bug: Protocol manager still processes streams when Studio inactive
When shouldProcess is false (Studio mode without active Studio), the code still calls protocolManager.responseStreamReceived, which processes and intercepts the response stream. The comment claims invokeSync returns undefined safely, but invokeSync only returns early if _protocol is undefined. Since isProtocolEnabled is true here, _protocol exists, so the stream gets processed anyway, defeating the PR's goal of preventing interception when Studio isn't open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In open mode, the Protocol Manager was intercepting and processing all response streams even when the Studio panel was not open.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Protocol interception now runs only when Studio is active; adds Studio AI access state and exposes mode, and always ends empty-body responses promptly.
packages/proxy/lib/http/response-middleware.ts):responseEndedWithEmptyBody,responseStreamReceived) onprotocolManager.isProtocolEnabledand Studio active state (mode === 'studio'withdbPath).packages/server/lib/cloud/protocol.ts):modegetter and addcanAccessStudioAIstate with setter; reset onclose().packages/server/lib/project-base.ts):protocolManager.setCanAccessStudioAI(...)during Studio initialization.packages/types/src/protocol.ts):ProtocolManagerShapewith optionalmode,canAccessStudioAI, andsetCanAccessStudioAI().Written by Cursor Bugbot for commit 303e990. This will update automatically on new commits. Configure here.